feat: enable filtering in delegated routing client #651
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
SgtPooki
reviewed
Oct 16, 2024
| @@ -64,7 +64,10 @@ export function libp2pDefaults (options: Libp2pDefaultsOptions = {}): Libp2pOpti | |||
| services: { | |||
| autoNAT: autoNAT(), | |||
| dcutr: dcutr(), | |||
| delegatedRouting: () => createDelegatedRoutingV1HttpApiClient('https://delegated-ipfs.dev'), | |||
| delegatedRouting: () => createDelegatedRoutingV1HttpApiClient('https://delegated-ipfs.dev', { | |||
| filterProtocols: ['unknown', 'transport-bitswap', 'transport-ipfs-gateway-http'], | |||
There was a problem hiding this comment.
what does the unknown filter protocol give us here? will that increase unreachable peers?
There was a problem hiding this comment.
TL;DR: it's to include DHT providers, whose protocol isn't explicitly bitswap (even though in almost all cases they support bitswap)
| @@ -73,7 +73,10 @@ export function libp2pDefaults (options: Libp2pDefaultsOptions = {}): Libp2pOpti | |||
| services: { | |||
| autoNAT: autoNAT(), | |||
| dcutr: dcutr(), | |||
| delegatedRouting: () => createDelegatedRoutingV1HttpApiClient('https://delegated-ipfs.dev'), | |||
| delegatedRouting: () => createDelegatedRoutingV1HttpApiClient('https://delegated-ipfs.dev', { | |||
| filterProtocols: ['unknown', 'transport-bitswap', 'transport-ipfs-gateway-http'], | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes & open questions
Change checklist