fix(server): 🩹 Using sessionID as a fallback to requests where referer is missing. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r is missing. Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
SgtPooki
approved these changes
Oct 20, 2023
src/heliaServer.ts
Outdated
| * Computes referer path for the request. | ||
| */ | ||
| private fetchRefererPath ({ request }: IRouteHandler): string { | ||
| let refererPath = new URL(request.headers.referer ?? 'http://ipfs.io').pathname |
There was a problem hiding this comment.
defaulting to 'ipfs.io' here seems wrong. why not default to ${currentUrl}?
There was a problem hiding this comment.
not currentUrl (because pathname) but request.hostname should work.
| private fetchRefererPath ({ request }: IRouteHandler): string { | ||
| let refererPath = new URL(request.headers.referer ?? 'http://ipfs.io').pathname | ||
| if (refererPath === '/') { | ||
| refererPath = request.sessionID |
There was a problem hiding this comment.
should we use sessionId in scenarios other than when refererPath === '/'?
There was a problem hiding this comment.
referrer should be more reliable, in most cases, this is just a fallback.
src/heliaServer.ts
Outdated
| /** | ||
| * Computes referer path for the request. | ||
| */ | ||
| private fetchRefererPath ({ request }: IRouteHandler): string { |
There was a problem hiding this comment.
Suggested change
| private fetchRefererPath ({ request }: IRouteHandler): string { | |
| private getRefererFromRouteHandler ({ request }: IRouteHandler): string { |
I don't think we should use the term fetch here.
Also, (joke) just because HTTP spec spells referrer wrong doesn't mean we need to? =P
There was a problem hiding this comment.
it was driving me crazy, sorry tired of seeing two different spellings.
| await heliaServer.isReady | ||
| app.use(session({ | ||
| genid: heliaServer.sessionId, | ||
| secret: 'very secret value' |
There was a problem hiding this comment.
nit: too secret of a value. please remove from commit history.
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
whizzzkid
added a commit
that referenced
this pull request
Oct 26, 2023
* main: (27 commits) feat(e2e): add /api/v0/repo/gc test chore: disable METRICS on CI e2e test runs test: add e2e test for /api/v0/version endpoint feat(server): ⚡️ Subdomain Gateway Using Fastify (#31) feat: use production level docker settings (#26) chore: remove unused playwright init code fix: use active LTS in package.json engines fix: playwright CI node-version=20 test: get clinic flame & doctor output from e2e tests test: e2e updates fix: use HOST constant in healthcheck fix: use HOST constant test: cleanup playwright test code test: add playwright tests feat: move HOST,PORT to src/constants.ts fix: ✏️ Fixing urls. (#23) fix: ✏️ helia-docker -> helia-http-gateway (#22) build(deps): Bump @babel/traverse and depcheck (#13) feat: add health-check (#21) fix(server): 🩹 Using sessionID as a fallback to requests where referer is missing. (#20) ... Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
sessionIDmaking it as a fallback later.