Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default Graphana port #148

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

achingbrain
Copy link
Member

The default port of 3000 conflicts with the Chrome devtools protocol port when using tiros.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

The default port of `3000` conflicts with the Chrome devtools
protocol port when using tiros.
@achingbrain
Copy link
Member Author

This could be a very specific solution to a very specific problem. I don't know if the convention for Graphana is port 3000, if it is this is probably not worth merging 🤷

@achingbrain achingbrain changed the title fix: change default prometheus port fix: change default Graphana port Apr 11, 2024
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also conflicts with service worker gateway. Thanks 🙏

@achingbrain achingbrain merged commit 1700c49 into main Apr 11, 2024
5 checks passed
@achingbrain achingbrain deleted the fix/change-prometheus-port branch April 11, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants