fix: split RPC API and HTTP Gateway servers #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To better conform to Kubo's pattern, run the RPC endpoints on port 5001 and the HTTP Gateway on port 8080. Also simplifies the Docker file, there's no need to rebuild OpenSSL, the version that comes with `node:20-slim` is fine.
anymore. since murat-dogan/node-datachannel#229 was resolved. |
SgtPooki
approved these changes
Apr 11, 2024
Aha, makes sense. Could have used a comment in the Dockerfile as to why we were rebuilding OpenSSL - it took ages and didn't seem to give us anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better conform to Kubo's pattern, run the RPC endpoints on port 5001 and the HTTP Gateway on port 8080.
Also simplifies the Docker file, there's no need to rebuild OpenSSL, the version that comes with
node:20-slimis fine.Change checklist