fix(server): 🐛 Redirecting to files with trailing slashes. (#15)

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

src/heliaFetch.ts

@@ -87,6 +87,13 @@ export class HeliaFetch {
     return result.groups as { namespace: string, address: string, relativePath: string }
   }
 
+  /**
+   * Remove duplicate slashes and trailing slashes from a path.
+   */
+  public sanitizeUrlPath (path: string): string {
+    return path.replace(/([^:]\/)\/+/g, '$1').replace(/\/$/, '')
+  }
+
   /**
    * fetch a path from IPFS or IPNS
    */
@@ -163,7 +170,7 @@ export class HeliaFetch {
       const directoryPath = options?.path ?? ''
       return async (): Promise<{ name: string, cid: CID }> => {
         try {
-          const path = `${directoryPath}/${file}`.replace(/\/\//g, '/')
+          const path = this.sanitizeUrlPath(`${directoryPath}/${file}`)
           this.log('Trying to get root file:', { file, directoryPath })
           const stats = await this.fs.stat(cid, { path })
           this.log('Got root file:', { file, directoryPath, stats })

src/heliaServer.ts

@@ -74,7 +74,7 @@ export class HeliaServer {
         }
         // absolute redirect
         this.log('Redirecting to relative to referer:', referrerPath)
-        response.redirect(301, relativeRedirectPath)
+        response.redirect(relativeRedirectPath)
       }
     } catch (error) {
       this.log('Error redirecting to relative path:', error)
@@ -125,9 +125,9 @@ export class HeliaServer {
         if (!request.originalUrl.startsWith(refererPath) &&
           (refNamespace === 'ipns' || refNamespace === 'ipfs')
         ) {
-          const finalUrl = `${request.headers.referer}/${reqDomain}/${relativePath}`.replace(/([^:]\/)\/+/g, '$1')
+          const finalUrl = this.heliaFetch.sanitizeUrlPath(`${request.headers.referer}/${reqDomain}/${relativePath}`)
           this.log('Redirecting to final URL:', finalUrl)
-          response.redirect(301, finalUrl)
+          response.redirect(finalUrl)
         }
       }
     }