This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(dagreader): remove a buggy workaround for a gateway issue
We had a hack that "pretended" seeking worked when it didn't as go's HTTP library uses seeks to determine the file size. However, 1. I'm changing the gateway to actually rely on seeking working as specified. 2. We don't even need this hack. The gateway performs two types of seeks (unless a range query is passed): 1. It seeks to the beginning. We can always shortcut this. 2. It seeks to the end. The gateway now has a special "lazy" seeker to avoid seeking until we actually try to _read_. Therefore, we don't need a hack for that either.
- Loading branch information
Showing
2 changed files
with
73 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters