This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
path: give a more helpful error when a case-coverted CIDv0 is likely #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous error message was technically accurate but not understandable by a layman who just pasted a CIDv0 into their browser.
lidel
suggested changes
Sep 24, 2021
There was a problem hiding this comment.
I am hesitant to make this change: it does not seem to improve much, there are more words, but one does not really know what next steps are to "fix this". Perhaps it should include a link to https://docs.ipfs.io/concepts/content-addressing/#cid-conversion?
@jessicaschilling @johnnymatthews quick temperature check?
|
Thanks for posting this. We're not going to accept this change currently as would ideally want an improved message to be more actionable (e.g., link to a URL). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous error message was technically accurate but not understandable by a
layman who just pasted a CIDv0 into their browser.
Motivation: ipfs/ipfs-companion#1006 (comment)
(Untested but this is a string-only change.)