Merge pull request #18 from ipfs/fix/no-components-error

fix: no components error

.gx/lastpubver

@@ -1 +1 @@
-1.1.28: QmdCKmdARJPTzGFmhQAdmiNkH8x1NYJ5nR3oTuyMSheGe1
+1.1.29: QmNqCEAGiUir2kPGTfYTADyKrdw9dHQ7MAaEAE5MGfXkcC

.travis.yml

@@ -0,0 +1,22 @@
+sudo: false
+
+
+language: go
+go:
+  - 1.11.x
+
+before_install:
+  - make deps
+
+script:
+  - bash <(curl -s https://github.com/raw/ipfs/ci-helpers/master/travis-ci/run-standard-tests.sh)
+
+after_success:
+  - bash <(curl -s https://codecov.io/bash)
+
+cache:
+  directories:
+    - $GOPATH/src/gx
+
+notifications:
+  email: false

Makefile

@@ -0,0 +1,11 @@
+gx:
+	go get github.com/whyrusleeping/gx
+	go get github.com/whyrusleeping/gx-go
+
+deps: gx
+	gx --verbose install --global
+	gx-go rewrite
+
+publish:
+	gx-go rewrite --undo
+

package.json

@@ -36,6 +36,6 @@
   "license": "",
   "name": "go-path",
   "releaseCmd": "git commit -a -m \"gx publish $VERSION\"",
-  "version": "1.1.28"
+  "version": "1.1.29"
 }
 

path.go

@@ -120,13 +120,18 @@ func ParsePath(txt string) (Path, error) {
 	//TODO: make this smarter
 	switch parts[1] {
 	case "ipfs", "ipld":
+		if parts[2] == "" {
+			return "", ErrNoComponents
+		}
 		// Validate Cid.
 		_, err := cid.Decode(parts[2])
 		if err != nil {
 			return "", err
 		}
 	case "ipns":
-		// No validation.
+		if parts[2] == "" {
+			return "", ErrNoComponents
+		}
 	default:
 		return "", ErrBadPath
 	}

path_test.go

@@ -37,6 +37,19 @@ func TestPathParsing(t *testing.T) {
 	}
 }
 
+func TestNoComponents(t *testing.T) {
+	for _, s := range []string{
+		"/ipfs/",
+		"/ipns/",
+		"/ipld/",
+	} {
+		_, err := ParsePath(s)
+		if err != ErrNoComponents {
+			t.Errorf("expected ErrNoComponents, got %s", err)
+		}
+	}
+}
+
 func TestIsJustAKey(t *testing.T) {
 	cases := map[string]bool{
 		"QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n":           true,