This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
use RW lock for the File's lock
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to, e.g., get the size, etc. in parallel.
schomatis
added
the
kind/enhancement
ghost
added
the
Stebalien
approved these changes
Dec 19, 2018
| @@ -118,8 +119,8 @@ func (fi *File) Open(flags int, sync bool) (FileDescriptor, error) { | |||
| // pretty much the same thing as here, we should at least call | |||
| // that function and wrap the `ErrNotUnixfs` with an MFS text. | |||
| func (fi *File) Size() (int64, error) { | |||
| fi.nodelk.Lock() | |||
| defer fi.nodelk.Unlock() | |||
There was a problem hiding this comment.
Doesn't have to happen in this PR but, ideally, we'd call GetNode() here instead of holding the lock.
There was a problem hiding this comment.
Yes, I have a couple of TODOs to refactor that (including also adding a SetNode() method).
| node := fi.node | ||
| fi.nodelk.Unlock() |
There was a problem hiding this comment.
Could also call GetNode here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on ipfs/kubo@feafd11 with the difference that in
flushUpwe keep theLock()call effectively taking the lock for writing since we're replacing the current node's value (@Stebalien please validate this).(Related to #32.)