Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BufferedDAG wrapping Batch as a DAGService. #48

Merged
merged 2 commits into from
Oct 27, 2018
Merged

Conversation

hsanjuan
Copy link
Contributor

I did this a bit in a hurry, but I'll check later.

@ghost ghost assigned hsanjuan Oct 26, 2018
@ghost ghost added the status/in-progress In progress label Oct 26, 2018
@hsanjuan hsanjuan changed the title Add BatchDAG wrapping Batch as a DAGService. Add BufferedDAG wrapping Batch as a DAGService. Oct 26, 2018
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I'm also rather tired so I'll leave it up to your judgment.

batch.go Show resolved Hide resolved
batch.go Outdated Show resolved Hide resolved
@hsanjuan hsanjuan merged commit b2d848b into master Oct 27, 2018
@ghost ghost removed the status/in-progress In progress label Oct 27, 2018
@hsanjuan hsanjuan deleted the feat/batching-ds branch October 27, 2018 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants