error when trying to encode an empty link #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
magik6k
approved these changes
Nov 2, 2018
phritz
reviewed
Nov 2, 2018
| A cid.Cid | ||
| } | ||
| type Bar struct { | ||
| A cid.Cid `refmt:",omitempty"` |
There was a problem hiding this comment.
The semantics without omitempty are surprising. I get that omitempty skips encoding zero values. But without omitempty you can't encode a zero value? What's the intent of semantics like that and what if I really, truly want an empty value?
So, in this case, the empty value we'd want is actually "null", not an empty CID. Unfortunately, refmt doesn't support nullable structs. One can, in fact, just use Really, I'd like to just add this feature to refmt. That is, I'd like to introduce a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't make nonsensical links.