-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to refmt #30
Merged
Commits on Sep 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9e7d558 - Browse repository at this point
Copy the full SHA 9e7d558View commit details -
Configuration menu - View commit details
-
Copy full SHA for e14a4d9 - Browse repository at this point
Copy the full SHA e14a4d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d048f4 - Browse repository at this point
Copy the full SHA 1d048f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c65d0f - Browse repository at this point
Copy the full SHA 3c65d0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5106752 - Browse repository at this point
Copy the full SHA 5106752View commit details -
Configuration menu - View commit details
-
Copy full SHA for 699e7a0 - Browse repository at this point
Copy the full SHA 699e7a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4982e8a - Browse repository at this point
Copy the full SHA 4982e8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e506e5e - Browse repository at this point
Copy the full SHA e506e5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9b953e - Browse repository at this point
Copy the full SHA f9b953eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e94e5a0 - Browse repository at this point
Copy the full SHA e94e5a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for eab8781 - Browse repository at this point
Copy the full SHA eab8781View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcd1522 - Browse repository at this point
Copy the full SHA fcd1522View commit details -
Configuration menu - View commit details
-
Copy full SHA for b29b7f4 - Browse repository at this point
Copy the full SHA b29b7f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 573c793 - Browse repository at this point
Copy the full SHA 573c793View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff21104 - Browse repository at this point
Copy the full SHA ff21104View commit details -
Configuration menu - View commit details
-
Copy full SHA for 666b656 - Browse repository at this point
Copy the full SHA 666b656View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31243bb - Browse repository at this point
Copy the full SHA 31243bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 782a191 - Browse repository at this point
Copy the full SHA 782a191View commit details -
share a pool of (un)marshallers
Also, use a cloner instead of unmarshalling when wrapping an object.
Configuration menu - View commit details
-
Copy full SHA for 679ed5f - Browse repository at this point
Copy the full SHA 679ed5fView commit details -
Increasing `numWorkers` doesn't seem to help at all (not supprising). Really, we could probably drop to NumCPUs (instad of 2x that) and we'd still be fine.
Configuration menu - View commit details
-
Copy full SHA for cd13b8b - Browse repository at this point
Copy the full SHA cd13b8bView commit details -
More than that doesn't help. +1 helps for the case where a goroutine holding a worker gets unscheduled.
Configuration menu - View commit details
-
Copy full SHA for ff48bd0 - Browse repository at this point
Copy the full SHA ff48bd0View commit details -
use a sync.Pool for the refmt (un)marshallers
IIRC, pools are cleaned every GC cycle. However, by benchmarks aren't actually *faster* with this change so I figured we might as well go for it. Our issue here is really throughput, not latency, so even *if* these pools are cleaned on GC, it's still useful.
Configuration menu - View commit details
-
Copy full SHA for e5cb584 - Browse repository at this point
Copy the full SHA e5cb584View commit details -
replace SetAtlas method with a constructor
We don't need to mutate, just replace.
Configuration menu - View commit details
-
Copy full SHA for 5896ec2 - Browse repository at this point
Copy the full SHA 5896ec2View commit details -
Make sure we *actually* serialize/deserialize. Addresses @warpfork's CR.
Configuration menu - View commit details
-
Copy full SHA for a1a7802 - Browse repository at this point
Copy the full SHA a1a7802View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.