ping: fix a bunch of issues #6312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #6298 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
(this should always have been done on the client, IMO, but, oh well...) License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Use PingResult errors for errors attached to individual pings. This is a (minor) BREAKING CHANGE. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
(fixes double printing of errors) License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned 
magik6k
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, update some deps. We needed to pull in a fix from libp2p and a fix from the commands lib. This also happens to pull in a few other nice fixes from libp2p :).