Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to go 1.11 #5483

Merged
merged 3 commits into from
Oct 9, 2018
Merged

switch to go 1.11 #5483

merged 3 commits into from
Oct 9, 2018

Conversation

Stebalien
Copy link
Member

Go 1.11 changes the output of go fmt slightly so we either need to
all downgrade or upgrade. Let's upgrade.

@ghost ghost assigned Stebalien Sep 17, 2018
@ghost ghost added the status/in-progress In progress label Sep 17, 2018
@Stebalien Stebalien added the status/blocked Unable to be worked further until needs are met label Sep 17, 2018
@Stebalien
Copy link
Member Author

Blocked on CI updates (and possibly a gx release)

@magik6k
Copy link
Member

magik6k commented Sep 17, 2018

@victorb
Copy link
Member

victorb commented Sep 18, 2018

Ok, ipfs-inactive/jenkins#126 was deployed, so I rebuilt this branch, but it's failing.

https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fgo-ipfs/detail/PR-5483/3/pipeline/14

==> Download complete!
==> using 'tar' to extract binary from archive
rm -f bin/gx-go
ln -s gx-go-v1.7.0 bin/gx-go
gx install --global
ERROR: Error: package 'go-ipfs' requires at least go version 1.11.
however, your gx-go binary was compiled with go1.10.2.
Please update gx-go (or recompile with your current go compiler)
ERROR: req-check hook failed: exit status 1 
mk/gx.mk:4: recipe for target 'gx-deps' failed
make: *** [gx-deps] Error 1
script returned exit code 2

@Stebalien
Copy link
Member Author

We need to cut a new gx-go release. I'm going to try to merge some fixes first.

@Kubuxu
Copy link
Member

Kubuxu commented Oct 8, 2018

Any progress on this?
This is blocking reuseport v2.

Go 1.11 changes the output of `go fmt` slightly so we either need to
all *downgrade* or *upgrade*. Let's upgrade.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien removed the status/blocked Unable to be worked further until needs are met label Oct 9, 2018
@Stebalien
Copy link
Member Author

So, I released a new GX but this is still failing saying that go 1.11 is not available. Does anything else need to be done to get it working?

@magik6k
Copy link
Member

magik6k commented Oct 9, 2018

You need to add a build to dists built with go1.11:

==> Using wget to download "https://ipfs.io/ipfs/QmYpvspyyUWQTE226NFWteXYJF3x3br25xmB6XzEoqfzyv/gx/v0.14.0/gx_v0.14.0_linux-amd64.tar.gz" to "bin/tmp/gx.tar.gz"

--2018-10-09 09:32:14--  https://ipfs.io/ipfs/QmYpvspyyUWQTE226NFWteXYJF3x3br25xmB6XzEoqfzyv/gx/v0.14.0/gx_v0.14.0_linux-amd64.tar.gz
Resolving ipfs.io (ipfs.io)... 209.94.78.81, 209.94.78.78, 209.94.78.79, ...
Connecting to ipfs.io (ipfs.io)|209.94.78.81|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2018-10-09 09:32:14 ERROR 404: Not Found.

Then set the hash in https://github.com/ipfs/go-ipfs/pull/5483/files#diff-31a09fc8a6f12712273987524eccb1faR3

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
Copy link
Member Author

Ah, thanks!

@Stebalien Stebalien merged commit 0f3485e into master Oct 9, 2018
@ghost ghost removed the status/in-progress In progress label Oct 9, 2018
@Stebalien Stebalien deleted the feat/go1.11 branch October 10, 2018 09:13
Voker57 pushed a commit to Voker57/go-ipfs that referenced this pull request Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants