Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Add go 1.11 tool #126

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Add go 1.11 tool #126

merged 1 commit into from
Sep 18, 2018

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 17, 2018

@ghost ghost assigned magik6k Sep 17, 2018
@ghost ghost added the pending review label Sep 17, 2018
@Stebalien
Copy link

Does this "just work" or do we need to cut a new gx release (and build it with go 1.11).

@magik6k
Copy link
Contributor Author

magik6k commented Sep 18, 2018

We need this first (to be able select go 1.11 in Jenkinsfile - which for go-ipfs happens in https://github.com/ipfs/go-ipfs/blob/master/ci/Jenkinsfile#L38)

@magik6k
Copy link
Contributor Author

magik6k commented Sep 18, 2018

(this needs to be merged and you need to ping @victorbjelkholm to kick jenkins in some way I don't know/have access to)

@victorb victorb merged commit 3c3b572 into master Sep 18, 2018
@ghost ghost removed the pending review label Sep 18, 2018
@victorb
Copy link
Collaborator

victorb commented Sep 18, 2018

Will confirm here once deployed.

@victorb
Copy link
Collaborator

victorb commented Sep 18, 2018

@magik6k @Stebalien ok, been deployed now and should be available in pipelines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants