ci: Archive sharness trash dirs #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
reviewed
Jun 3, 2018
ci/Jenkinsfile
Outdated
|
|
||
| try { | ||
| // archive trash directories if any | ||
| def trashdirs = run(returnStdout: true, script: "find test/sharness -name 'trash\\ *' | grep .") |
There was a problem hiding this comment.
Can this not all be reduced to?
sh "tar -czf sharnessTrashDirs-${osname}.tar.gz trash*/"
(I'm not familiar with Jenkins)
magik6k
force-pushed
the
feat/ci/archive-trash-dirs
branch
2 times, most recently
from
6416075
to
f7fa6cf
Compare
|
@magik6k this appears to be causing problems on macos (failing in a way that's making the tests fail even though we ignore the results from macos). |
|
@magik6k @victorbjelkholm are the mac failures related to this change? or are they independently being super dumb? |
|
Apparently, not related. |
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
magik6k
force-pushed
the
feat/ci/archive-trash-dirs
branch
from
f7fa6cf
to
39b76d5
Compare
|
rebased |
|
Seems useful to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this CI will archive any leftover sharness trash directories, this should help debugging failing sharness tests.
Example: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fgo-ipfs/detail/feat%2Fci%2Farchive-trash-dirs/46/artifacts