Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

fix: don't hold the pin lock while updating pins #2

Merged
merged 1 commit into from
Feb 17, 2020
Merged

fix: don't hold the pin lock while updating pins #2

merged 1 commit into from
Feb 17, 2020

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien mentioned this pull request Feb 15, 2020
Closed
@ianopolous ianopolous mentioned this pull request Feb 16, 2020
Closed
dirkmc
dirkmc approved these changes Feb 17, 2020
View reviewed changes
Copy link

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Stebalien Stebalien merged commit 92e4fe9 into master Feb 17, 2020
@gammazero gammazero deleted the fix/unlock-while-pinning branch October 19, 2020 17:06
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023
@Stebalien
Merge pull request ipfs/go-ipfs-pinner#2 from ipfs/fix/unlock-while-p…
d471370 
…inning

fix: don't hold the pin lock while updating pins

This commit was moved from ipfs/go-ipfs-pinner@92e4fe9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirkmc dirkmc dirkmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadlock in GC
2 participants
@Stebalien @dirkmc