Skip to content
This repository has been archived by the owner on Oct 5, 2023. It is now read-only.

Initial implementation #1

Merged
merged 71 commits into from
Feb 23, 2019
Merged

Initial implementation #1

merged 71 commits into from
Feb 23, 2019

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Nov 6, 2018

Depends on:

@ghost ghost assigned magik6k Dec 20, 2018
@ghost ghost added the status/in-progress In progress label Dec 20, 2018
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just nits at this point. However, this needs more documentation. I'm required by my OKRs to insist on this 😄.

api.go Outdated Show resolved Hide resolved
api.go Outdated Show resolved Hide resolved
api.go Outdated Show resolved Hide resolved
pin.go Show resolved Hide resolved
response.go Outdated Show resolved Hide resolved
response.go Outdated Show resolved Hide resolved
request.go Outdated Show resolved Hide resolved
swarm.go Outdated Show resolved Hide resolved
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit lost with Decode. I believe we want to assert that we get exactly one response, right? Or are we trying to decode the final response?

api.go Outdated Show resolved Hide resolved
response.go Outdated Show resolved Hide resolved
response.go Outdated Show resolved Hide resolved
response.go Outdated Show resolved Hide resolved
response.go Outdated
err = nil
}
return err
return json.NewDecoder(r.Output).Decode(dec)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final (I promise) nit: We should return the close error (could contain a trailing error).

decoder := json.NewDecoder(r.Output)
if err := decoder.Decode(dec); err != nil {
  return err
}
return res.Close()

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

(although I'm not sure what's wrong with travis)

response.go Outdated Show resolved Hide resolved
@magik6k
Copy link
Member Author

magik6k commented Feb 23, 2019

🚢

@magik6k magik6k merged commit 449b614 into master Feb 23, 2019
@ghost ghost removed the status/in-progress In progress label Feb 23, 2019
@Stebalien Stebalien deleted the feat/implement branch March 29, 2019 13:47
Jorropo pushed a commit to ipfs/kubo that referenced this pull request May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants