Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

fix the content disposition header #14

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

Stebalien
Copy link
Member

  • needs a name parameter
  • "file" isn't a valid disposition

see https://github.com/ipfs/ipfs/issues/395

@ghost ghost assigned Stebalien Mar 20, 2019
@ghost ghost added the status/in-progress In progress label Mar 20, 2019
@Stebalien
Copy link
Member Author

Alternative to #8.

  1. This handles non-form uses (uses disposition "attachment" instead of "form-data").
  2. Use the same name for all fields.

@Stebalien Stebalien requested a review from magik6k March 20, 2019 07:09
* needs a name parameter
* "file" isn't a valid disposition

see https://github.com/ipfs/ipfs/issues/395
@Stebalien Stebalien force-pushed the fix/content-disposition-header branch from 3e92e7d to cff97fc Compare March 20, 2019 07:20
@Stebalien Stebalien merged commit 883a000 into master Mar 20, 2019
@Stebalien Stebalien deleted the fix/content-disposition-header branch March 20, 2019 15:52
@ghost ghost removed the status/in-progress In progress label Mar 20, 2019
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 11, 2023
…ition-header

fix the content disposition header

This commit was moved from ipfs/go-ipfs-files@883a000
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants