Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

profile: add badger truncate option #20

Merged
merged 1 commit into from
Nov 27, 2018
Merged

profile: add badger truncate option #20

merged 1 commit into from
Nov 27, 2018

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented Oct 29, 2018 •
edited
Loading

@schomatis schomatis added the status/in-progress In progress label Oct 29, 2018
@schomatis schomatis self-assigned this Oct 29, 2018
@schomatis schomatis mentioned this pull request Oct 29, 2018
Merged
magik6k
magik6k approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't turn this option on for existing nodes with badger (we'd need to invert the option), but I guess this is good enough

@schomatis
Copy link
Contributor Author

This won't turn this option on for existing nodes with badger (we'd need to invert the option), but I guess this is good enough

Could you elaborate on this? Similarly to syncWrites, if truncate is not found in the config file it will be set to true.

@magik6k
Copy link
Member

magik6k commented Nov 6, 2018

Ah, right, forgot about that thing

@Stebalien Stebalien merged commit e4bfe7e into ipfs:master Nov 27, 2018
@ghost ghost removed the status/in-progress In progress label Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees

@schomatis schomatis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schomatis @magik6k @Stebalien