This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
feat: Add DNS.MaxCacheTTL for DNS-over-HTTPS resolvers #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add an optional parameter to set a maximum TTL for DNS-over-HTTPS resolver
This comment has been minimized.
This comment has been minimized.
|
@marten-seemann would you know who is able to review this change? |
|
This is on the review list for go-ipfs v0.13.0 ipfs/kubo#8615. |
lidel
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
LGTM, merging and switching ipfs/kubo#8615 to upstream version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be used to expose
WithMaxCacheTTLoption of go-doh-resolver, which release is tracked in libp2p/go-doh-resolver#15.