forward the remaining of the stdin args to the server #83
Conversation
ghost
assigned 
|
This should probably have some tests... any other feedback? |
Stebalien
force-pushed
the
fix/forward-args
branch
from
6240f2b
to
a1bb029
Compare
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=========================================
+ Coverage 43.02% 43.6% +0.57%
=========================================
Files 23 24 +1
Lines 1922 1961 +39
=========================================
+ Hits 827 855 +28
- Misses 960 970 +10
- Partials 135 136 +1
Continue to review full report at Codecov.
|
| @@ -0,0 +1,66 @@ | |||
| package cmds | |||
There was a problem hiding this comment.
Need to be able to continue treating the argument reader as an io.ReadCloser so we can't use bufio.Scanner.
cli/parse_test.go
Outdated
| } else if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| bodyArgs = append(bodyArgs, next) |
There was a problem hiding this comment.
This interface is a bit awkward but I'm not a fan of the scanner interface either.
| // However, such is life. | ||
| fileReader = files.NewMultiFileReader(files.NewSliceFile("", "", []files.File{ | ||
| files.NewReaderFile("stdin", "", bodyArgs, nil), | ||
| }), true) |
|
(for the record, I hate this PR) |
|
A couple tests would be nice just so we don't have to wait until it gets bubbled up into ipfs to see any regressions |
Note: I've already bubbled it to test and it seems to be working (the one issue is a slight change in an error message). |
I have little preference so I'll switch back to it. |
Stebalien
force-pushed
the
fix/forward-args
branch
from
ec4e83f
to
49a26f3
Compare
Apparently, it's not thread-safe.
Stebalien
force-pushed
the
fix/forward-args
branch
from
f8697b6
to
9160bdc
Compare
No description provided.