Support encoing using IPLD-Prime codecs #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warpfork
approved these changes
Jul 27, 2021
Comment on lines
+199
to
+205
| // In addition to the explicitly named legacy encoders defined in this file, | ||
| // support encoding with the encoders registered in the ipld-prime multicodec | ||
| // registry. | ||
| ipldCodec, ok := mc.Of(string(encType)) | ||
| if !ok { | ||
| if !ok { | ||
| n, err := strconv.Atoi(string(encType)) |
There was a problem hiding this comment.
This seems like two new features:
- more string names supported
- base-10 numbers supported
Are there docs changes that should go with it?
|
we no longer need this PR based on the current state of ipfs/kubo#7995 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for an argument of
--encoding=dag-jsonor other valid ipld-prime codecs to be used in commands likedag get, where a dag node is being encoded to stdout.Note: this relies on ipfs/kubo#7976 so that the node returned from the command is an ipld prime node that the encoder can successfully encode. When the return value is not an ipld prime node, and an ipld-prime codec is chosen, an error that an invalid node time has been attempted to be encoded is emitted.