#183 refactored the request options conversion code per the ticket requirements #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now options are converted and saved before the request object is generated
hsanjuan
reviewed
Mar 26, 2020
There was a problem hiding this comment.
LGTM, but @Stebalien should give a final ok (assuming this is what #183 wanted).
Stebalien
approved these changes
Mar 26, 2020
|
@gargdeepak do you have time to go for the gold medal and address the suggestions or should we merge as is? |
added 2 commits
March 26, 2020 17:50
|
@hsanjuan fix on the way |
|
@Stebalien pushed fixes per PR comments. Ready to be reviewed |
hsanjuan
approved these changes
Mar 27, 2020
|
How do I merge this PR ? Github says: |
You don't have to. I will let @Stebalien as main maintainer and requester of the change hit the merge button. |
Stebalien
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now options are converted and saved before the request object is generated