merge in go-ipfs-cmdkit #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way we can share the code with the legace commands package and don't have to convert everything
We usually only keep go-ipfs in the rewritten state. We leave dependencies unrewritten.
Run standard gofmt command on project root.
|
Ya know, nobody's going to object to this and it "just works". |
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges go-ipfs-cmdkit back into go-ipfs-cmds. That package was extracted as a common dependency for the legacy commands library and the new one but the split is no longer necessary (and is kind of a pain).
cmdkit PR: ipfs/go-ipfs-cmdkit#34
Specifically, this just: