http: use the request context #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
force-pushed
the
fix/http-context
branch
from
5c1828c
to
80dbf04
Compare
Stebalien
commented
Apr 30, 2019
| Context() context.Context | ||
| } | ||
| // Environment is the environment passed to commands. | ||
| type Environment interface{} |
There was a problem hiding this comment.
(doesn't break anything in either go-filecoin or go-ipfs)
There was a problem hiding this comment.
Should MakeEnvironment be removed/altered with this?
There was a problem hiding this comment.
We still need the environment (we type assert it to something more useful).
Really, we should consider stashing everything we'd usually put in the environment in the context (which is, IMO, where it should go) but we can handle that later.
magik6k
approved these changes
May 11, 2019
http/parse.go
Outdated
| @@ -1,7 +1,8 @@ | |||
| package http | |||
|
|
|||
| import ( | |||
| "context" | |||
| "crypto/rand" | |||
There was a problem hiding this comment.
May want to use 'math/rand', it's 10-30x faster
CloseNotifier has been deprecated for a while. Also, ditch the "environment" context. We don't actually _need_ this.
Stebalien
force-pushed
the
fix/http-context
branch
from
80dbf04
to
8d7fadf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloseNotifier has been deprecated for a while.
Also, ditch the "environment" context. We don't actually need this.