Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double error message #148

Closed
Stebalien opened this issue Mar 1, 2019 · 0 comments · Fixed by #149
Closed

Double error message #148

Stebalien opened this issue Mar 1, 2019 · 0 comments · Fixed by #149
Assignees
@Stebalien

Comments

@Stebalien
Copy link
Member

I'm seeing errors being printed twice from CLI commands. Specifically:

  1. After commands(dht): return final error kubo#6034, ipfs dht put foo foo.
  2. Canceling ipfs dht findprovs .... It prints "canceled" followed by "context canceled".
Stebalien added a commit that referenced this issue Mar 1, 2019
@Stebalien
don't return copied errors from Copy
775e8f1 
We _copy_ the error to the response, we only need to return errors encountered
when copying.

fixes #148
@Stebalien Stebalien mentioned this issue Mar 1, 2019
Merged
@ghost ghost assigned Stebalien Mar 1, 2019
@ghost ghost added the status/in-progress In progress label Mar 1, 2019
Stebalien added a commit that referenced this issue Mar 1, 2019
@Stebalien
don't return copied errors from Copy
d345582 
We _copy_ the error to the response, we only need to return errors encountered
when copying.

fixes #148
@ghost ghost removed the status/in-progress In progress label Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't return copied errors from Copy ipfs/go-ipfs-cmds
1 participant
@Stebalien