This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Update go-ipfs-files to 2.0 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
11 tasks
|
(Tests pass for me locally, and they should start passing once this and go-ipfs-files refactor are merged) |
Stebalien
previously approved these changes
Dec 13, 2018
Stebalien
dismissed
their stale review
(still needs a gx update, I think: CI doesn't pass)
|
It doesn't pass because ci isn't using gx here |
|
Ah... Got it. |
Stebalien
approved these changes
Dec 13, 2018
|
(tests pass for me locally) |
|
The files were not go fmt'ed and tests failed in master because of that. Please do not merge changes with failing tests. If CI isn't using Gx and that's an issue, make it use it. I fixed it for you. |
|
Fair point. I thought there was a reason we couldn't use gx but I should have investigated this more. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ipfs/go-ipfs-files#2