Ready for universal CI #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add traversal fix (sort on write)
Resolve all errors from go vet and go static check
hannahhoward
force-pushed
the
feat/ready-for-ci
branch
from
bc0b9ed
to
0a83688
Compare
mvdan
approved these changes
Aug 5, 2021
| p peer.ID | ||
| amount uint64 | ||
| p peer.ID //nolint:structcheck | ||
| amount uint64 //nolint:structcheck |
There was a problem hiding this comment.
what warning is this preventing? as far as I know our unified CI only enforces vet and staticcheck, so structcheck should not be a part of any of this.
There was a problem hiding this comment.
it gets the CURRENT CI to pass :P
There was a problem hiding this comment.
🤦 need to rush to remove golangci-lint, then :P
There was a problem hiding this comment.
I'll remove the nolint comment in the PR where we switch over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Fix all go vet / staticcheck errors
Implementation
go vetUnkeyed fields errorsFor discussion
go-graphsync has some unreliable tests on Circle-CI, and I'm sure those will be accentuated when we switch over to Universal CI, as they were with go-bitswap. So we'll need to do seperate work there.