open files on windows with shared delete mode #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Apr 9, 2020
| @@ -0,0 +1,93 @@ | |||
| // +build windows | |||
There was a problem hiding this comment.
let's document that we got this from golang (license, attribution, etc.)
| return | ||
| } | ||
|
|
||
| func tempFile(dir, pattern string) (f *os.File, err error) { |
There was a problem hiding this comment.
Actually, now that we're doing this, we should rename the temporary file while it's open. If we do that, nobody will be able to re-open the file without the share delete flag.
|
subsumed by #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #70
suggestions welcome on any hints on the set of operations into the datastore that would trigger a windows failure before but we are hopeful might not anymore