Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only log when we find a file we don't expect #68

Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix: only log when we find a file we don't expect #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions flatfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,12 @@ func (fs *Datastore) encode(key datastore.Key) (dir, file string) {
}

func (fs *Datastore) decode(file string) (key datastore.Key, ok bool) {
if filepath.Ext(file) != extension {
if !strings.HasSuffix(file, extension) {
// We expect random files like "put-". Log when we encounter
// others.
if !strings.HasPrefix(file, "put-") {
log.Warnw("failed to decode flatfs filename", "file", file)
}
return datastore.Key{}, false
}
name := file[:len(file)-len(extension)]
Expand Down Expand Up @@ -1064,7 +1069,7 @@ func (fs *Datastore) walk(path string, qrb *query.ResultBuilder) error {

key, ok := fs.decode(fn)
if !ok {
log.Warnw("failed to decode flatfs entry", "file", fn)
// not a block.
continue
}

Expand Down