Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Add Provide RPC #37

Merged
merged 11 commits into from
Aug 10, 2022
Merged

Add Provide RPC #37

merged 11 commits into from
Aug 10, 2022

Conversation

willscott
Copy link
Contributor

ajnavarro
ajnavarro reviewed Aug 3, 2022
View reviewed changes
Copy link
Member

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we implement the actually not supported method Provide on contentrouting.go too? thanks!

client/findproviders.go Outdated Show resolved Hide resolved
client/provide.go Show resolved Hide resolved
client/provide.go Outdated Show resolved Hide resolved
@willscott
Copy link
Contributor Author

@ajnavarro I believe I addressed all your comments

@ajnavarro ajnavarro self-requested a review August 8, 2022 11:12
ajnavarro
ajnavarro reviewed Aug 8, 2022
View reviewed changes
client/findproviders.go Outdated Show resolved Hide resolved
client/provide.go Show resolved Hide resolved
ajnavarro
ajnavarro approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willscott willscott merged commit a6fd1a5 into ipfs:main Aug 10, 2022
@willscott willscott deleted the feat/provide branch August 10, 2022 10:50
@BigLep BigLep mentioned this pull request Aug 12, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajnavarro ajnavarro ajnavarro approved these changes

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willscott @ajnavarro