Add RawKey function and make use of it. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like I broke something. Will fix. |
Avoids some unnecessary creation of strings.
kevina
force-pushed
the
kevina/rawkey
branch
from
f7a1aaa
to
f397865
Compare
|
Should be fixed now. |
|
@whyrusleeping should be good to go |
| @@ -29,8 +28,8 @@ func PrefixTransform(prefix ds.Key) ktds.KeyTransform { | |||
| panic("expected prefix not found") | |||
| } | |||
|
|
|||
| s := strings.TrimPrefix(k.String(), prefix.String()) | |||
| return ds.NewKey(s) | |||
| s := k.String()[len(prefix.String()):] | |||
There was a problem hiding this comment.
You should make sure to do a bounds check here.
There was a problem hiding this comment.
I could but then what, panic. Also it is redundant because if prefix.IsAncestorOf passes then there is no way for this to be out of bounds.
There was a problem hiding this comment.
Ah, i see. I didnt realize we already had that expectation here.
|
LGTM, thanks!` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids some unnecessary creation of strings.
This decreased the time to retrieve 100,000 small (1000 byte) blocks (see ipfs/kubo#3376) from around 245 ms to 205 ms.