Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the keytransform datastore's query implementation #127

Merged
merged 7 commits into from
Apr 19, 2019
Merged

fix the keytransform datastore's query implementation #127

merged 7 commits into from
Apr 19, 2019

Commits on Apr 18, 2019

  1. ktds: idiomatic use of interfaces 

    Motivation: I want to be able to use the concrete type from a different package
but I can't.

This:

1. Exports the concrete datastore type and avoids returning private types from
   public functions.
2. Removes the mostly useless ktds interface. Unfortunately, it collides with
   the idiomatic name for the datastore itself.

This could break something referencing the `ktds.Datastore` type but nothing is
doing that.
    @Stebalien
    Stebalien committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    d28fbf6 View commit details
    Browse the repository at this point in the history

  2. fix the keytransform datastore's query implementation 

    The namespace Datastore shouldn't have to touch the mess with the query.

Note: this _also_ correctly applies ordering, filters, etc. to the transformed
keys (in both the namespaced and the key transform datastores).
    @Stebalien
    Stebalien committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    7194f47 View commit details
    Browse the repository at this point in the history

  3. test: add ordering tests

    @Stebalien
    Stebalien committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    6b29409 View commit details
    Browse the repository at this point in the history

  4. test: improve query tests

    @Stebalien
    Stebalien committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    086377d View commit details
    Browse the repository at this point in the history

  5. ktds: explain how we apply orders

    @Stebalien
    Stebalien committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    74196ce View commit details
    Browse the repository at this point in the history

  6. query: make compare by value work for all comparisons

    @Stebalien
    Stebalien committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    54ed9bc View commit details
    Browse the repository at this point in the history

  7. test: improve query coverage

    @Stebalien
    Stebalien committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    ffc9f91 View commit details
    Browse the repository at this point in the history