query: make datastore ordering act like a user would expect #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies orders hierarchically. Unfortunately, the interfaces had to be
changed significantly to get this to work.
For example `[OrderByValue{}, SortByKey{}]` *used* to re-sort by key, throwing
away the value sort. Now, this acts like a normal database and `SortByKey` will
only sort within equivalent values.
ghost
assigned 
Stebalien
added
the
status/blocked
Stebalien
added a commit
to ipfs/go-ds-sql
that referenced
this pull request
Jan 24, 2019
Stebalien
added a commit
to ipfs/go-ds-badger
that referenced
this pull request
Jan 24, 2019
Stebalien
added a commit
to ipfs/go-ds-leveldb
that referenced
this pull request
Jan 24, 2019
Stebalien
removed
the
status/blocked
raulk
reviewed
Jan 24, 2019
raulk
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies orders hierarchically. Unfortunately, the interfaces had to be changed significantly to get this to work.
For example
[OrderByValue{}, SortByKey{}]used to re-sort by key, throwing away the value sort. Now, this acts like a normal database andSortByKeywill only sort within equivalent values.[[BREAKING CHANGE]]
PRs for datastores:
(and probably more)
This is all because we had to change
NaiveOrder. Unfortunately, the old interface simply can't support this kind of sorting.