Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parsing issues and nits #97

Merged
merged 4 commits into from
Dec 3, 2019
Merged

fix parsing issues and nits #97

merged 4 commits into from
Dec 3, 2019

Commits on Dec 3, 2019

  1. fix: avoid panicing if we try to parse a non-sha multihash as a CIDv0 

    I'm pretty sure we never call `Parse` multihashes anyways, but we should be careful.
    @Stebalien
    Stebalien committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    58b483a View commit details
    Browse the repository at this point in the history

  2. chore: avoid re-validated already validated CIDs

    @Stebalien
    Stebalien committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    08e15f8 View commit details
    Browse the repository at this point in the history

  3. chore: avoid magic numbers

    @Stebalien
    Stebalien committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    60ab0f8 View commit details
    Browse the repository at this point in the history

  4. test: test parsing non-sha256 hashes

    @Stebalien
    Stebalien committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    5df8995 View commit details
    Browse the repository at this point in the history