This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix(messagequeue): Remove second run loop #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert to the old go-routine architecture for the messagequeue, which I believe is still compatible w/ wantlist w/o mutex fix #92
ghost
assigned 
Stebalien
approved these changes
Mar 4, 2019
|
This can only help, even if it doesn't fully fix the issue. |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…ance fix(messagequeue): Remove second run loop This commit was moved from ipfs/go-bitswap@7fd8d7c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Ideally, fix #92
Implementation
Revert to the old go-routine architecture for the messagequeue.
I originally setup the second go-routine because I believed I needed to block access to the wantlist inside a go-routine, which no longer has a mutex. however, I now see that the lock that was previously used for building the outgoing message actually covers all cases where the wantlist is modified. At minimum, it can't hurt to revert to previous setup and remove the loop that is causing so many problems. It is difficult to tell if the problem however is related to the loop itself or just sending more messages.
This does pass go test --race FWIW.