Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

fix: fix race on "responsive" check #528

Merged
merged 1 commit into from
Sep 15, 2021
Merged

fix: fix race on "responsive" check #528

merged 1 commit into from
Sep 15, 2021

Conversation

Stebalien
Copy link
Member

fixes #527

@Stebalien Stebalien mentioned this pull request Sep 2, 2021
Closed
@Stebalien
Copy link
Member Author

Added an extra check to return early if we don't know about the peer.

@aschmahmann
Copy link
Contributor

This PR seems to be hitting some flaky tests that have not yet been reported in ipfs/boxo#86. Let's put up a PR to disable those tests, rebase and see if we have more flaky tests or something else is going on.

@Stebalien Stebalien merged commit fef017b into master Sep 15, 2021
@Stebalien Stebalien deleted the fix/responsive-check-race branch September 15, 2021 14:37
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
Jorropo pushed a commit to Jorropo/go-libipfs that referenced this pull request Jan 26, 2023
@Stebalien
Merge pull request ipfs/go-bitswap#528 from ipfs/fix/responsive-check…
04cf894 
…-race

fix: fix race on "responsive" check

This commit was moved from ipfs/go-bitswap@fef017b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential race condition detected
3 participants
@Stebalien @aschmahmann @marten-seemann