This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
refactor: simplify messageQueue onSent #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Apr 13, 2020
| mq.bcstWants.MarkSent(bcstEntries[i]) | ||
| } | ||
| for i := 0; i < peerSentCount; i++ { | ||
| mq.peerWants.MarkSent(peerEntries[i]) |
There was a problem hiding this comment.
This won't quite work as we will have removed some of the peer wants to peers that don't support HAVE.
There was a problem hiding this comment.
We remove them when we realize the peer doesn't support HAVE, so in MarkSent() we could just check if they've already been removed from pending before adding them to sent.
But actually I think it's clearer to put them in a list. I pushed a commit with this change.
Stebalien
approved these changes
Apr 13, 2020
| @@ -566,6 +566,7 @@ func (mq *MessageQueue) extractOutgoingMessage(supportsHave bool) (bsmsg.BitSwap | |||
| } | |||
|
|
|||
| // Add each regular want-have / want-block to the message | |||
| peerSent := make([]wantlist.Entry, 0, len(peerEntries)) | |||
There was a problem hiding this comment.
nit: we can actually reuse the original slice if we do this correctly. But this is a low priority as I'm pretty sure we're going to delete this code when we land #347.
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…-onSent refactor: simplify messageQueue onSent This commit was moved from ipfs/go-bitswap@6099047
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.