Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Refactor: use global pubsub notifier #177

Merged
merged 4 commits into from
Aug 15, 2019

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Aug 14, 2019

This will enable us to pass around CIDs instead of Blocks (Fixes #173)

@dirkmc dirkmc marked this pull request as ready for review August 14, 2019 15:01
@dirkmc dirkmc requested a review from Stebalien August 14, 2019 15:02
@dirkmc
Copy link
Contributor Author

dirkmc commented Aug 14, 2019

Seems like there's a bash error running the benchmarks, I'm not sure what that's about?

/bin/bash: -c: line 16: syntax error near unexpected token `)'

@Stebalien
Copy link
Member

Crap.

@Stebalien Stebalien force-pushed the refactor/use-global-pubsub-notifier branch from 38c68e7 to 38c6f53 Compare August 15, 2019 00:21
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot simpler than I thought it would be!

bitswap.go Show resolved Hide resolved
sessionmanager/sessionmanager.go Outdated Show resolved Hide resolved
bitswap.go Show resolved Hide resolved
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Stebalien Stebalien merged commit c980d7e into master Aug 15, 2019
@Stebalien Stebalien deleted the refactor/use-global-pubsub-notifier branch August 15, 2019 19:32
Jorropo pushed a commit to Jorropo/go-libipfs that referenced this pull request Jan 26, 2023
…pubsub-notifier

Refactor: use global pubsub notifier

This commit was moved from ipfs/go-bitswap@c980d7e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid keeping blocks in memory longer than we need to
2 participants