This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix some naming nits and broadcast on search #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed peers This fixes the case where: 1. I start downloading something. 2. A friend jumps on our WiFi. 3. Our IPFS daemons connect via local discovery. 4. I never notice that they have the file I'm looking for because I'm already downloading it from a peer. 5. The peer I'm downloading from is _really_ slow.
Stebalien
commented
Jun 12, 2019
| func (s *Session) handleRebroadcast(ctx context.Context) { | ||
|
|
||
| if len(s.liveWants) == 0 { | ||
| func (s *Session) handlePeriodicSearch(ctx context.Context) { |
There was a problem hiding this comment.
I guess this is now a rebroadcast, but, IMO, periodic search is still more accurate.
hannahhoward
approved these changes
Jun 12, 2019
Stebalien
added a commit
that referenced
this pull request
Jul 4, 2019
fix some naming nits and broadcast on search
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.