This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
WIP improve provider request rate limiting #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we ever have multiple parallel find provider requests for the same session? |
|
@Stebalien yes we could. |
hannahhoward
force-pushed
the
feat/remove-simultaneous-provider-limit
branch
from
820f40a
to
43cbefc
Compare
remove rate limit on simultaneous requests for more providers License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
force-pushed
the
feat/remove-simultaneous-provider-limit
branch
from
43cbefc
to
a2c78b0
Compare
|
SO this seems to be doing well on the gateways... I wonder if we should move toward a merge. How processor intensive are find provider requests? If we dedup requests (already part of this code), can we just go ahead and remove the rate limit? |
|
Status: I'd like to move this rate limiting down into the DHT itself and make it configurable on a per-node basis. |
|
ok closing then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The Gateway is having issues seemingly due to getting backed up looking for more providers for requests.
Implementation
-- So far, just remove rate limit on simultaneous requests for more providers completely in this branch -- which we will deploy to the gateway to test efficacy.
-- if successful, we will decide on an optimal strategy and implement