Skip to content

Commit

Permalink
fix(tar): test http status and not error string in body (#221)
Browse files Browse the repository at this point in the history
* Look for correct error message

The error message in boxo was fixed to say "not allowed" instead of "now allowed". The message that the gateway conformance test looks for needs to match.

* refactor: make test backward-compatible

---------

Co-authored-by: Marcin Rataj <lidel@lidel.org>
  • Loading branch information
gammazero and lidel authored Aug 9, 2024
1 parent f1d01d3 commit b65f03b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.6.2] - 2024-08-09
### Changed
- Relaxed negative test of TAR response [#221](https://github.com/ipfs/gateway-conformance/pull/221)

## [0.6.1] - 2024-07-29
### Changed
- Support meaningful `Cache-Control` on generated UnixFS directory listing responses on `/ipfs` namespace
Expand Down
5 changes: 2 additions & 3 deletions tests/path_gateway_tar_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,12 @@ func TestTar(t *testing.T) {
},
{
Name: "GET TAR with relative paths outside root fails",
Hint: "relative UnixFS paths outside the root are not allowed",
Request: Request().
Path("/ipfs/{{cid}}", outsideRootCID).
Query("format", "tar"),
Response: Expect().
Body(
Contains("relative UnixFS paths outside the root are now allowed"),
),
StatusBetween(400, 599),
},
{
Name: "GET TAR with relative paths inside root works",
Expand Down

0 comments on commit b65f03b

Please sign in to comment.