Skip to content

Commit

Permalink
chore: apply suggestions from review
Browse files Browse the repository at this point in the history
Co-authored-by: Marcin Rataj <lidel@lidel.org>
  • Loading branch information
hacdias and lidel committed Jun 6, 2023
1 parent 96fa851 commit 54ef60f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions tests/t0118_gateway_car_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ func TestGatewayCarPathing(t *testing.T) {
{
Name: "GET default CAR response with pathing through UnixFS Directory",
Hint: `
CAR stream is not deterministic, as blocks can arrive in random order,
but if we have a small file that fits into a single block, and export its CID
we will get a CAR that is a deterministic array of bytes.
CAR stream of a UnixFS file within a path under UnixFS subdirectory should contain
all the blocks to traverse the path, as well as all the blocks behind
the last path segment (terminating entity returned recursively).
`,
Request: Request().
Path("/ipfs/{{cid}}/subdir/ascii.txt", subdirTwoSingleBlockFilesFixture.MustGetCid()).
Expand All @@ -40,7 +40,7 @@ func TestGatewayCarPathing(t *testing.T) {
),
},
{
Name: "GET default CAR response of UnixFS file on a path with sharded directory",
Name: "GET default CAR response of UnixFS file on a path with HAMT-sharded directory",
Hint: `
CAR stream of a UnixFS file within a path with sharded directory should contain
all the blocks to traverse the path, as well as all the blocks contained inside
Expand Down
2 changes: 1 addition & 1 deletion tooling/helpers/car.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func applyStandardCarResponseHeaders(t *testing.T, st test.SugarTest) test.Sugar
// Hint("CAR is streamed, gateway may not have the entire thing, unable to calculate total size").
// IsEmpty(),
test.Header("X-Content-Type-Options").
Hint("CAR is streamed, gateway may not have the entire thing, unable to calculate total size").
Hint("Content type sniffing should be explicitly disabled via nosniff header.").
Equals("nosniff"),
test.Header("Accept-Ranges").
Hint("CAR is streamed, gateway may not have the entire thing, unable to support range-requests. Partial downloads and resumes should be handled using IPLD selectors: https://github.com/ipfs/go-ipfs/issues/8769").
Expand Down

0 comments on commit 54ef60f

Please sign in to comment.