Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint note to javascript guidelines #233

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Add lint note to javascript guidelines #233

merged 1 commit into from
Feb 10, 2017

Conversation

RichardLitt
Copy link
Member

This adds a note about aegir-lint. See #225 (comment)

This adds a note about aegir-lint. See #225 (comment)
@dignifiedquire
Copy link
Member

Lgtm

@RichardLitt RichardLitt merged commit 95fa675 into master Feb 10, 2017
@RichardLitt RichardLitt deleted the feat/add-lint branch February 10, 2017 15:55
@RichardLitt RichardLitt removed the status/in-progress In progress label Feb 10, 2017
@@ -97,6 +97,8 @@ IPFS JavaScript projects default to [standard](https://github.com/feross/standar

However, we've added an extra linting rule: Enforce the use of [strict mode](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode). This avoids issues we had when using ES2015 features outside of strict mode. We enforce this rule by using [eslint](http://eslint.org/) and extending [standard module](https://github.com/feross/standard) with the [eslint-config-standard](https://github.com/feross/eslint-config-standard).

Using [aegir-lint](#aegir) will help you do this easily; it automatically lints your documents.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documents? Should be code, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants