Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: uci/copy-templates #431

Merged
merged 10 commits into from
Aug 22, 2023
Merged

ci: uci/copy-templates #431

merged 10 commits into from
Aug 22, 2023

Conversation

web3-bot
Copy link
Collaborator

This PR was created automatically by the @web3-bot as a part of the Unified CI project.

@web3-bot web3-bot requested a review from a team as a code owner August 14, 2023 11:28
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #431 (413047e) into main (01bd4a0) will increase coverage by 11.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #431       +/-   ##
===========================================
+ Coverage   49.75%   61.15%   +11.39%     
===========================================
  Files         249      205       -44     
  Lines       30125    24399     -5726     
===========================================
- Hits        14988    14920       -68     
+ Misses      13690     8030     -5660     
- Partials     1447     1449        +2     
Files Changed Coverage Δ
...itswap/testnet/internet_latency_delay_generator.go 85.71% <ø> (ø)
examples/unixfs-file-cid/main.go 41.21% <ø> (ø)

... and 57 files with indirect coverage changes

@hacdias hacdias mentioned this pull request Aug 15, 2023
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 CI

@Jorropo Jorropo dismissed their stale review August 15, 2023 12:14

I thought this was the Kubo PR, this is easy to fix once go-libp2p is released.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green + we've merged #434 which iiuc removes some problems with go1.20.

@Jorropo ok to merge or is go-libp2p bump here a problem?

@Jorropo
Copy link
Contributor

Jorropo commented Aug 22, 2023

Assuming the abspath updates are RFM this is ok. cc @hacdias

@hacdias hacdias enabled auto-merge (squash) August 22, 2023 09:58
@hacdias hacdias merged commit 9e804b4 into main Aug 22, 2023
13 checks passed
@hacdias hacdias deleted the uci/copy-templates branch August 22, 2023 10:18
hacdias added a commit that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants