provider: add breaking changes to the changelog #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog for: #273
hacdias
reviewed
Jun 1, 2023
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
==========================================
- Coverage 50.67% 50.66% -0.01%
==========================================
Files 280 280
Lines 33756 33756
==========================================
- Hits 17106 17103 -3
- Misses 14871 14873 +2
- Partials 1779 1780 +1 |
Co-authored-by: Henrique Dias <hacdias@gmail.com>
Jorropo
added a commit
that referenced
this pull request
Jun 2, 2023
This reverts commits: - 0ff6929: provider: add breaking changes to the changelog (#330) - 0962ed6: relocated magic numbers, updated Reprovide Interval from 24h to 22h - ac047a5: provider: refactor to only maintain one batched implementation and add throughput callback This seems to have an unknown deadlock that is blocking Kubo's sharness tests, the code coverage is also pretty bad I forgot to migrate the pinning reproviding tests because they weren't ran directly over batched. https://app.codecov.io/gh/ipfs/boxo/commit/20e2aae45ec6ecd21c905993c394e9cc767c9038/tree/provider Revert "0962ed63b07127b95a67423c3ddf820558b3d829: relocated magic numbers, updated Reprovide Interval from 24h to 22h" This reverts commit 0962ed6. Revert "provider: refactor to only maintain one batched implementation and add throughput callback" This reverts commit ac047a5.
Jorropo
added a commit
that referenced
this pull request
Jun 2, 2023
This reverts commits: - 0ff6929: provider: add breaking changes to the changelog (#330) - 0962ed6: relocated magic numbers, updated Reprovide Interval from 24h to 22h - ac047a5: provider: refactor to only maintain one batched implementation and add throughput callback This seems to have an unknown deadlock that is blocking Kubo's sharness tests, the code coverage is also pretty bad I forgot to migrate the pinning reproviding tests because they weren't ran directly over batched. https://app.codecov.io/gh/ipfs/boxo/commit/20e2aae45ec6ecd21c905993c394e9cc767c9038/tree/provider
Jorropo
added a commit
that referenced
this pull request
Jun 2, 2023
This reverts commits: - 0ff6929: provider: add breaking changes to the changelog (#330) - 0962ed6: relocated magic numbers, updated Reprovide Interval from 24h to 22h - ac047a5: provider: refactor to only maintain one batched implementation and add throughput callback This seems to have an unknown deadlock that is blocking Kubo's sharness tests, the code coverage is also pretty bad I forgot to migrate the pinning reproviding tests because they weren't ran directly over batched. https://app.codecov.io/gh/ipfs/boxo/commit/20e2aae45ec6ecd21c905993c394e9cc767c9038/tree/provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog for: #273