Fixed serialisation issue with multiadds (#49)

This commit was moved from ipfs/go-delegated-routing@ee4cdad
ipfs · Sep 15, 2022 · cbcf08b · cbcf08b
1 parent be5d6db
commit cbcf08b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/routing/http/client/provide.go b/routing/http/client/provide.go
@@ -139,8 +139,8 @@ func bytesToMA(b []byte) (interface{}, error) {
 	return multiaddr.NewMultiaddrBytes(b)
 }
 func maToBytes(iface interface{}) ([]byte, error) {
-	if ma, ok := iface.(multiaddr.Multiaddr); ok {
-		return ma.Bytes(), nil
+	if ma, ok := iface.(*multiaddr.Multiaddr); ok {
+		return (*ma).Bytes(), nil
 	}
 	return nil, fmt.Errorf("did not get expected MA type")
 }

diff --git a/routing/http/test/provide_test.go b/routing/http/test/provide_test.go
@@ -11,6 +11,7 @@ import (
 	"github.com/libp2p/go-libp2p-core/crypto"
 	"github.com/libp2p/go-libp2p-core/peer"
 	multiaddr "github.com/multiformats/go-multiaddr"
+	"github.com/multiformats/go-multicodec"
 	"github.com/multiformats/go-multihash"
 )
 
@@ -34,12 +35,17 @@ func TestProvideRoundtrip(t *testing.T) {
 		t.Fatal("should get sync error on unsigned provide request.")
 	}
 
+	ma, err := multiaddr.NewMultiaddr("/ip4/0.0.0.0/tcp/4001")
+	if err != nil {
+		t.Fatal(err)
+	}
+
 	c, s := createClientAndServer(t, testDelegatedRoutingService{}, &client.Provider{
 		Peer: peer.AddrInfo{
 			ID:    pID,
-			Addrs: []multiaddr.Multiaddr{},
+			Addrs: []multiaddr.Multiaddr{ma},
 		},
-		ProviderProto: []client.TransferProtocol{},
+		ProviderProto: []client.TransferProtocol{{Codec: multicodec.TransportBitswap}},
 	}, priv)
 	defer s.Close()