Skip to content

Commit

Permalink
test: fix put with hash test
Browse files Browse the repository at this point in the history
We just changed ID/"id" to IDENTITY/"identity" to match the multicodec table and
avoid confusion with peer IDs, CIDs, etc.

Unfortunately, this breaks the `--hash=id` flag. Luckily, I'm pretty sure
nobody's actually using this. As putting a block with an identity hash is
useless. If they are users, we can go about adding in backwards compatibility
hacks later.


This commit was moved from ipfs/interface-go-ipfs-core@6ebdbe7
  • Loading branch information
Stebalien committed Aug 23, 2019
1 parent 361023c commit 7b3e2ba
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions coreiface/tests/dag.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func (tp *TestSuite) TestPutWithHash(t *testing.T) {
t.Fatal(err)
}

nd, err := ipldcbor.FromJSON(strings.NewReader(`"Hello"`), mh.ID, -1)
nd, err := ipldcbor.FromJSON(strings.NewReader(`"Hello"`), mh.SHA3_256, -1)
if err != nil {
t.Fatal(err)
}
Expand All @@ -81,7 +81,7 @@ func (tp *TestSuite) TestPutWithHash(t *testing.T) {
t.Fatal(err)
}

if nd.Cid().String() != "bafyqabtfjbswy3dp" {
if nd.Cid().String() != "bafyrmifu7haikttpqqgc5ewvmp76z3z4ebp7h2ph4memw7dq4nt6btmxny" {
t.Errorf("got wrong cid: %s", nd.Cid().String())
}
}
Expand Down

0 comments on commit 7b3e2ba

Please sign in to comment.