feat: update package.json linter config #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hugomrdias
commented
Dec 15, 2020
hugomrdias
commented
- add a few new rules
- update engine to =>12
- add double license option
- add a few new rules - update engine to =>12 - add double license option
achingbrain
reviewed
Dec 15, 2020
| "require-version": "error", | ||
| "bin-type": "error", | ||
| "files-type": "error", | ||
| "version-type": "error", | ||
| "valid-values-engines": ["error", [ | ||
| { | ||
| "node": ">=10.0.0", | ||
| "node": ">=12.0.0", |
There was a problem hiding this comment.
We only support LTS and Current so this should be >=14.0.0
achingbrain
reviewed
Dec 15, 2020
| @@ -5,14 +5,15 @@ | |||
| "require-bugs": "error", | |||
| "require-bundledDependencies": "off", | |||
| "require-config": "off", | |||
| "require-contributors": "off", | |||
| "require-contributors": "error", | |||
There was a problem hiding this comment.
This will error when the contributors field is absent, right? ipfs has contributors in the root package.json but not always in the modules under /packages as otherwise we'd have to compare the paths of edits during our update-contributors step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.